[ci/cd] Make the next branch easy to deploy #241
Conversation
mdartic
force-pushed
the
239-build
branch
2 times, most recently
from
d0eadde
to
9fe8a47
Compare
mdartic
changed the title
mdartic
force-pushed
the
239-build
branch
7 times, most recently
from
0a01e7d
to
0053d31
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #241 +/- ##
=====================================
Coverage ? 0
=====================================
Files ? 0
Lines ? 0
Branches ? 0
=====================================
Hits ? 0
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
mdartic
force-pushed
the
239-build
branch
17 times, most recently
from
e91d1a2
to
8eb8485
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mdartic
force-pushed
the
239-build
branch
5 times, most recently
from
20a4d7e
to
7dc489d
Compare
| */ | ||
| addLayout( | ||
| { | ||
| src: resolve(layoutsDir, './WithHeader.vue'), |
There was a problem hiding this comment.
I didn't see change in file using layout. Is this normal?
There was a problem hiding this comment.
Yes.
Adding layout was clearly breaking the build and usage of the nuxt module, as it was referencing files in the module.
This seems not OK, but I didn't find any documentation on this.
Pages using layouts inside the module are OK.
Pages in the app using our nuxt-locokit module won't have access to our layouts, until our layouts need other files of the module (like paths).
So, for now, I don't have other work around for this. I simply remove the addLayout.
And this is fine as we were not using layouts in our nuxt playground / app.
* remove log in nuxt module * remove routes file in nuxt module * remove auth login page (legacy code)
|
Kudos, SonarCloud Quality Gate passed!
|
No description provided.