Switch Markdown library #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joel
added a commit
that referenced
this pull request
Apr 15, 2014
…_jruby_support Switch Markdown library
|
Hello, I'm all for JRuby support. But because kramdown is pure Ruby vs Redcarpet which has C extensions, it's probable (that's worth checking though) that kramdown is slower than Redcarpet on CRuby. JRuby is likely to be faster than C Ruby anyway, but eventually on CRuby this change could make LocomotiveCMS slower. So I wonder if this is okay to just use kramedown as you did or if it's better to conditionally switch to kramdown depending on the selected Ruby Runtime (with a common abstraction wrapper to manipulate it). Not a big deal, just wondering... |
marcreynolds
pushed a commit
to ezeratech/steam
that referenced
this pull request
Sep 13, 2016
…n_library_for_jruby_support Switch Markdown library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #21