Middleware as a mass noun #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Corrected "middlewares" to "middleware" - Simplified middleware configset, "middleware/" unnecessary - Replaced `RuntimeException` with `ContainerValueNotFoundException` when middleware not found - Updated README with service container definitions and usage for middleware
mcaskill
force-pushed
the
mcaskill-middleware
branch
from
5cff40b
to
59a3a7d
Compare
|
Closing this pull request because it has been inactive for over 313 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
By dropping the prefix, we take better advantage of our snake_case v. CamelCase features if ever we eventually upgrade to a more mature (and real) dependency injection container
RuntimeExceptionwithContainerValueNotFoundExceptionwhen middleware not found to be more in line with PSR-11 recommendations