Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize and edit header/footer partials #7

Closed
wants to merge 2 commits into from
Closed

Reorganize and edit header/footer partials #7

wants to merge 2 commits into from

Conversation

hum-n
Copy link
Contributor

@hum-n hum-n commented Jul 5, 2017

If we want to split the header and footer into multiple files, I would go all the way. Something like that.

@hum-n hum-n requested a review from mducharme July 5, 2017 15:43
@dominiclord
Copy link
Member

Personnally, I prefer (and have been doing) boilerplate/template/partial/site-header. Clear enough, and no need for more namespaces.

Following the trait trend, you'd get Boilerplate/Template/Partial/SiteHeaderTrait.

@hum-n
Copy link
Contributor Author

hum-n commented Jul 5, 2017

Yea I don't mind the single file either, but if we keep it multiple, I think it's cleaner in folders than how it is currently.

@mcaskill mcaskill closed this Nov 4, 2019
@mcaskill mcaskill deleted the baker-header branch February 7, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mducharme mducharme Awaiting requested review from mducharme

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hum-n @dominiclord @mcaskill