Fix issues due to pip 10 release #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tappan-at-git
approved these changes
May 1, 2018
| @@ -71,8 +75,8 @@ def __init__(self, | |||
|
|
|||
| self.preinstall = preinstall | |||
| self.upgrade_pip = upgrade_pip | |||
| self.pip_version = pip_version | |||
There was a problem hiding this comment.
Should this have a # (pbovbel): allow pinning the pip version?
|
|
||
| # (pbovbel): make logging optional, since --log overrides -q flag for pip | ||
| if log_file: | ||
| self.log_file = log_file |
There was a problem hiding this comment.
I would assign self.log_file=None when log_file is false-y, to avoid having the exposed attributes change based on its __init__ arguments.
| # Add in any user supplied pip args | ||
| self.pip_args.extend(extra_pip_arg) | ||
|
|
||
| # (pbovbel) Update pip_upgrade_args to keep flags like -q |
| # First, bootstrap pip with a reduced option set (well-supported options) | ||
| print(self.pip_preinstall_prefix + self.pip_upgrade_args + ['-U', 'pip']) | ||
| subprocess.check_call(self.pip_preinstall_prefix + self.pip_upgrade_args + ['-U', 'pip']) | ||
| print(self.pip_preinstall_prefix + self.pip_upgrade_args + ['-U', pip_package]) |
There was a problem hiding this comment.
Easier to keep these strings in sync if you assigned it to a variable and used it for both, but I recognize that means diverging from upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lock down pip version at 9.0.3