Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up extra_pip_args PR #31

Merged
merged 3 commits into from
Dec 3, 2018
Merged

Clean up extra_pip_args PR #31

merged 3 commits into from
Dec 3, 2018

Conversation

paulbovbel
Copy link
Contributor

@paulbovbel paulbovbel commented Dec 3, 2018 •
edited
Loading

FYI @knorth55, supercedes #23

  • Disable py3 builds to get tests to pass
  • Move cmake escape processing to a common place

There's some meta-escaping going on here (\\\') that I do not fully understand, but it seems to work better than anything I can come up with for the cmake->make->argparse chain.

garyservin
garyservin approved these changes Dec 3, 2018
View reviewed changes
Copy link
Contributor

@garyservin garyservin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulbovbel paulbovbel merged commit 237fece into devel Dec 3, 2018
@paulbovbel paulbovbel deleted the add-extra-pip-args branch March 18, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyservin garyservin garyservin approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulbovbel @garyservin @knorth55