First python2 issue of 2020 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbovbel
commented
Jan 16, 2020
| @@ -204,8 +181,8 @@ def install_dependencies(self): | |||
| # (pbovbel) allow pinning the pip version | |||
| pip_package = 'pip==' + self.pip_version if self.pip_version else 'pip' | |||
| # First, bootstrap pip with a reduced option set (well-supported options) | |||
| print(self.pip_preinstall_prefix + self.pip_upgrade_args + ['-U', pip_package]) | |||
paulbovbel
commented
Jan 16, 2020
| if self.verbose: | ||
| virtualenv.append('--verbose') | ||
| if self.verbose: | ||
| virtualenv.append('--verbose') |
There was a problem hiding this comment.
--verbose not supported by python -m venv
paulbovbel
commented
Jan 16, 2020
| @@ -130,28 +128,6 @@ def __init__(self, | |||
| # (pbovbel) Set pip_upgrade_args here to keep flags like -q, disregard L111 above. | |||
| self.pip_upgrade_args = self.pip_args | |||
|
|
|||
| @classmethod | |||
| def from_options(cls, package, options): | |||
paulbovbel
commented
Jan 16, 2020
| @@ -87,7 +86,6 @@ def __init__(self, | |||
| self.pip_version = pip_version | |||
| self.extra_virtualenv_arg = extra_virtualenv_arg | |||
| self.verbose = verbose | |||
| self.setuptools = setuptools | |||
There was a problem hiding this comment.
this option is not really relevant - either way you end up with setuptools in the virtualenv
paulbovbel
commented
Jan 16, 2020
| @@ -89,7 +89,7 @@ if __name__ == '__main__': | |||
| log_file=None, | |||
| builtin_venv=check_module(python_executable, 'venv'), | |||
| builtin_pip=check_module(python_executable, 'pip'), | |||
| pip_version='19.0.3' # (pbovbel) known working version | |||
| pip_version='19.3.1' # (pbovbel) known working version | |||
There was a problem hiding this comment.
may as well try a new pip
garyservin
approved these changes
Jan 16, 2020
ablakey
approved these changes
Jan 16, 2020
garyservin
pushed a commit
that referenced
this pull request
Feb 5, 2020
* Clean up options, virtualenv installs setuptools by default * Make sure we install a compatible setuptools version for py2 venv
|
This PR solves our problems! |
|
@knorth55, done, thanks for the reminder. |
|
@paulbovbel Sorry, but do you have plan to release this to kinetic? |
|
Thank you for releasing!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test build here http://tailor.locusbots.io/blue/organizations/jenkins/ci%2Ftailor-distro/detail/0.1.16/120/pipeline
Newly released setuptools (45) explicitly not compatible with python2, so we need to make sure we install an older one in py2 venvs.