RST-3172 Check that requirements file is locked #62
Conversation
paulbovbel
force-pushed
the
check-venv
branch
6 times, most recently
from
56abf99
to
ee9903a
Compare
paulbovbel
changed the title
paulbovbel
force-pushed
the
check-venv
branch
6 times, most recently
from
e3b94ae
to
3997b66
Compare
paulbovbel
force-pushed
the
check-venv
branch
2 times, most recently
from
299ad4c
to
1ed764a
Compare
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/env python | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
I really got tired of the python2 subprocess module. Onward!
paulbovbel
changed the title
|
|
||
| args = parser.parse_args() | ||
|
|
||
| extra_pip_args = args.extra_pip_args[1:-1] |
There was a problem hiding this comment.
It's weird that args.extra_pip_args includes the wrapping "". Somewhere along the line extra quotes are being inserted?
There was a problem hiding this comment.
Yeah, it was some weird mess with passing args from cmake list->shell->python, where some of those args are prefixed with - but shouldn't be processed by argparse...
I won't pretend this is the best way - I mostly got there via trial and error until something worked.
There was a problem hiding this comment.
Maybe args.extra_pip_args.strip("\"\'") would be more robust if some of this pipeline changes.
catkin_virtualenv/scripts/venv_check
Outdated
| parser.add_argument( | ||
| '--requirements', required=True, help="Requirements to check.") | ||
| parser.add_argument( | ||
| '--extra-pip-args', default="\"\"", type=str, help="Extra pip args for install.") |
There was a problem hiding this comment.
This any different from '""' ?
There was a problem hiding this comment.
I think black will complain about '""' :(
There was a problem hiding this comment.
Huh. Dunno why I didn't think of that earlier, works for me.
From discussion with @abencz, we probably don't want to blindly recommend INPUT_REQUIREMENTS, and instead just ensure that requirements are actually locked.
This actually satisfies the spirit of the RST-3172 better, since we can detect any insufficiently locked requirements.
Sneaks in a python3 port of catkin_virtualenv proper.