Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require catkin_package to be called before catkin_generate_virtualenv #67

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Don't require catkin_package to be called before catkin_generate_virtualenv #67

merged 2 commits into from
Jul 9, 2020

Conversation

paulbovbel
Copy link
Contributor

@paulbovbel paulbovbel commented Jul 8, 2020 •
edited
Loading

Mitigate a common user error

@paulbovbel paulbovbel requested review from DLu and ablakey July 8, 2020 19:35
@paulbovbel paulbovbel merged commit 1eb95b6 into master Jul 9, 2020
@DLu
Copy link
Contributor

DLu commented Jul 9, 2020

Thank you for this. Apologies for being an error-prone common user.

@paulbovbel paulbovbel deleted the no-catkin-package branch July 28, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ablakey ablakey ablakey approved these changes

@DLu DLu Awaiting requested review from DLu

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulbovbel @DLu @ablakey