[RST-2437] Ensure that all variables are updated #103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that all variables are updated when the update_variables flag is set. Previously, only variables involved in motion model segments that needed to be generated were being updated. Variables involved in previously generated segments were left untouched. This could result in incorrect initial state guesses being used for those variables.
As an example, imagine a sensor transaction that connects two adjacent states at T1 and T2, and a second transaction that connects T1 to T3. If both of these transactions are added to the graph at the same time:
With this PR, if the
update_variables
flag is set, any variable from a previously generated motion model segment that is also involved in the current transaction is updated from the value stored in the motion model history.