Draw RelativePose2DStampedConstraint constraints #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@svwilliams Could you paste the test failure error here, please? I suspect it's related with the version of |
|
|
Thanks, it's that. Let me know if you prefer me to copy the It's a shame they don't allow to easily compound those classes 😞 |
|
I'll take a look at everything in the next couple of days. |
|
At least for now, I'm trying to maintain compatibility back to Kinetic. So if you need functionality that doesn't go back that far, I'd say you need to duplicate the Or you can always release fuse_viz as a separate package, outside of the main fuse repo. Then you can add whatever version restrictions you want. |
efernandez
force-pushed
the
draw_constraints_upstream
branch
from
8460c79
to
f775f8c
Compare
|
I've reverted the last commit, which is the one that requires |
svwilliams
approved these changes
Nov 26, 2019
This includes: * Dynamically generate display properties for the constraint sources * Cache the constraint sources properties config so it's applied when the properties are later created * Create Variable visual + property, as we do for the Constraint
This reverts commit 8b2e683. This allows to use the rviz version shipped with Kinetic, and we only need to revert this commit when we decide to drop backwards compatibility with Kinetic or older versions of rviz.
efernandez
force-pushed
the
draw_constraints_upstream
branch
from
f775f8c
to
9069544
Compare
|
@svwilliams I addressed your comments and rebased this on top of the current |
matthewbwhitaker
approved these changes
Nov 26, 2019
This was referenced Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes:
the properties are later created
Below you can see how the display looks like, its properties and visual objects, and what can be done to inspect a
fuse_msgs::SerializedGraphmessage using this PR. Before only the variables were rendered.I've recently merged this same thing into our fork so we get some testing on it: clearpathrobotics#2
Also note this requires
rviz>= 1.13.4, but if that's an issue, I can make it work with a lower version. The reason is that I try to re-use code for the covariance property and visual, but it requires their code to be duplicated. Withrviz>= 1.13.4, at least I don't have to duplicate the visual code, although I still have for the property one.