Throttle optimization duration exceeded warning #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svwilliams
approved these changes
Feb 10, 2020
| ROS_WARN_STREAM("Optimization exceeded the configured duration by " << | ||
| (optimization_complete - optimization_deadline) << "s"); | ||
| ROS_WARN_STREAM_THROTTLE(10.0, "Optimization exceeded the configured duration by " | ||
| << (optimization_complete - optimization_deadline) << "s"); |
There was a problem hiding this comment.
Spacing looks weird on github
There was a problem hiding this comment.
Well, that's actually the spacing I get for those two lines with my clang-format configuration. I have a vim plugin that uses it, so I can run :Autoformat on specific lines.
I can change it if you want.
Although it'd be great if we can have a .clang-format file in the fuse packages. 😃
ayrton04
approved these changes
Feb 13, 2020
This was referenced Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the optimization exceeds the configured duration, it's likely to happen quite often, so I think it's better to throttle the
ROS_WARNmessage that reports that.In a future PR we could also try to make the optimization duration available in the diagnostics.