C++14 for test_unicycle_2d_state_cost_function #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@svwilliams @ayrton04 for review |
svwilliams
approved these changes
Mar 13, 2020
ayrton04
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_unicycle_2d_state_cost_functionalso needsc++14. This PR does that and also remove theif(TARGETblock, which isn't used by other test targets.Without this, I get the following compilation error when running
make run_tests:In file included from /home/efernandez/dev/ws/cpr_ws/src/fuse/fuse_models/include/fuse_models/unicycle_2d_predict.h:38:0, from /home/efernandez/dev/ws/cpr_ws/src/fuse/fuse_models/include/fuse_models/unicycle_2d_state_cost_function.h:37, from /home/efernandez/dev/ws/cpr_ws/src/fuse/fuse_models/test/test_unicycle_2d_state_cost_function.cpp:34: /opt/clearpath/2.18/include/fuse_core/util.h: In function ‘fuse_core::Matrix<Scalar, Size, Size> fuse_core::getCovarianceDiagonalParam(const ros::NodeHandle&, const string&, Scalar)’: /opt/clearpath/2.18/include/fuse_core/util.h:215:28: error: use of ‘auto’ in lambda parameter declaration only available with -std=c++14 or -std=gnu++14 [](const auto& value) { return value < Scalar(0); })) // NOLINT(whitespace/braces) ^ CMakeFiles/test_unicycle_2d_state_cost_function.dir/build.make:62: recipe for target 'CMakeFiles/test_unicycle_2d_state_cost_function.dir/test/test_unicycle_2d_state_cost_function.cpp.o' failed