Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thread synchronization issue in the fixed-lag smoother #172

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

svwilliams
Copy link
Contributor

The started/ignited variables are accessed from multiple threads. Changing them to atomic instead.

@svwilliams svwilliams requested a review from ayrton04 April 9, 2020 21:34
Copy link
Collaborator

@efernandez efernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the pending_transactions_mutex_ was protecting the started_ and ignited_ flags, but I see some methods where they are changed without locking that mutex:

So this LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants