Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuse -> ROS 2 fuse_core: Linting #292

Merged

Conversation

methylDragon
Copy link
Collaborator

See: #276

Description

  • Fixes linting. Nuff said.
  • Also migrates .h files to .hpp files!

Lots of files got changed!

It's a wrap for fuse_core (at least until we need to circle back for waitables)
Pinging @svwilliams for visibility.

Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
fuse_doc/doc/.templates/full_globaltoc.html Outdated Show resolved Hide resolved
fuse_core/include/fuse_core/time.h Outdated Show resolved Hide resolved
fuse_core/test/test_timestamp_manager.cpp Outdated Show resolved Hide resolved
fuse_core/include/fuse_core/parameter.hpp Outdated Show resolved Hide resolved
fuse_core/include/fuse_core/parameter.hpp Outdated Show resolved Hide resolved
fuse_core/include/fuse_core/parameter.hpp Outdated Show resolved Hide resolved
fuse_core/include/fuse_core/transaction.hpp Show resolved Hide resolved
fuse_core/include/fuse_core/util.hpp Outdated Show resolved Hide resolved
Signed-off-by: methylDragon <methylDragon@gmail.com>
Copy link
Collaborator

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and all tests in fuse_core pass locally using Rolling deps from the testing repo on Jammy

@methylDragon methylDragon merged commit 046368c into locusrobotics:rolling Dec 1, 2022
@methylDragon methylDragon deleted the rolling-core-linting branch December 1, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants