fuse -> ROS 2 fuse_variables: Linting #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 tasks
methylDragon
force-pushed
the
rolling-variables-linting
branch
from
bd9d0f6
to
5dee971
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
rolling-variables-linting
branch
from
5dee971
to
d4ea263
Compare
sloretz
reviewed
Dec 8, 2022
| 0.0, 0.0, 0.0, | ||
| 0.0, 0.0, 0.0, | ||
| 0.0, 0.0, 0.0; | ||
| 0.0, 0.0, 0.0, |
There was a problem hiding this comment.
nit, indenting looked intentional, could use /* *INDENT-OFF* */ and /* *INDENT-OFF* */ here
| 0.0, 0.0, 0.0, | ||
| 0.0, 0.0, 0.0, | ||
| 0.0, 0.0, 0.0; | ||
| 0.0, 0.0, 0.0, |
There was a problem hiding this comment.
same comment about indentation
|
|
||
| double x[4] = {qw, qx, qy, qz}; | ||
| fuse_core::MatrixXd actual(3, 4); | ||
| actual << 0.0, 0.0, 0.0, 0.0, | ||
| 0.0, 0.0, 0.0, 0.0, | ||
| 0.0, 0.0, 0.0, 0.0; | ||
| 0.0, 0.0, 0.0, 0.0, |
| bool success = parameterization->ComputeMinusJacobian(x, actual.data()); | ||
|
|
||
| fuse_core::MatrixXd expected(3, 4); | ||
| expected << 0.0, 0.0, 0.0, 0.0, | ||
| 0.0, 0.0, 0.0, 0.0, | ||
| 0.0, 0.0, 0.0, 0.0; | ||
| 0.0, 0.0, 0.0, 0.0, |
methylDragon
force-pushed
the
rolling-variables-linting
branch
from
d4ea263
to
298a6ef
Compare
sloretz
reviewed
Dec 8, 2022
fuse_variables/include/fuse_variables/orientation_3d_stamped.hpp
Outdated
Show resolved
Hide resolved
fuse_variables/include/fuse_variables/orientation_3d_stamped.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
rolling-variables-linting
branch
from
298a6ef
to
8013ad1
Compare
sloretz
approved these changes
Dec 8, 2022
|
@ros-pull-request-builder retest this please! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #276
I also noticed that some package.xmls were missing the schema link (causing them to get skipped over by xmllint. That's been fixed for all packages completed so far.
Pinging @svwilliams for visibility.