fuse -> ROS 2 fuse_constraints : Linting #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 tasks
sloretz
reviewed
Dec 9, 2022
| @@ -246,8 +278,8 @@ TEST(AbsoluteConstraint, Optimization) | |||
| mean1 << 1.0, 2.0, 3.0; | |||
| fuse_core::Matrix3d cov1; | |||
| cov1 << 1.0, 0.0, 0.0, | |||
| 0.0, 1.0, 0.0, | |||
| 0.0, 0.0, 1.0; | |||
| 0.0, 1.0, 0.0, | |||
There was a problem hiding this comment.
73be208 !
I also fixed the copyright (I had to make extremely minor changes to get ament_copyright to be satisfied), and fixed the pragma warning on fuse_core/macros.h
(For the pragma, I realized what happened was macros.h got migrated macros.hpp (when it was an already deprecated file, so I pointed both of them to fuse_macros.hpp.)
I can also remove macros.hpp if that's preferable (since macros.h is supposed to be deprecated anyway?)
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
rolling-constraints-linting
branch
2 times, most recently
from
73be208
to
cd98e08
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
rolling-constraints-linting
branch
from
cd98e08
to
051c24f
Compare
|
@ros-pull-request-builder retest this please |
sloretz
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #276
Pinging @svwilliams for visibility.