fuse -> ROS 2 fuse_publishers : Linting #305
Conversation
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
fuse_core/include/fuse_core/util.hpp
Outdated
| if (a.back() == '/') { | ||
| a.pop_back(); | ||
| } | ||
| if (b.front() == '/') { |
There was a problem hiding this comment.
I would recommend forbidding b from beginning with a / or a ~. Either of those characters at the start means b is an absolute topic/service/action name which normally aren't affected by namespacing. If they normally aren't affected by namespacing, then I'd also expect them to not be able to be prepended with something.
| @@ -31,38 +31,40 @@ | |||
| * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | |||
| * POSSIBILITY OF SUCH DAMAGE. | |||
| */ | |||
|
|
|||
| // Workaround ros2/geometry2#242 | |||
There was a problem hiding this comment.
I think this comment is in the wrong spot, or maybe the workaround is not needed. The workaround was to include <tf2_geometry_msgs/tf2_geometry_msgs.hpp> before <tf2/utils.h>, but that's not what's happening here.
There was a problem hiding this comment.
I ended up reordering them just in case
166b39a
| @@ -31,66 +31,76 @@ | |||
| * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | |||
| * POSSIBILITY OF SUCH DAMAGE. | |||
| */ | |||
|
|
|||
| // Workaround ros2/geometry2#242 | |||
There was a problem hiding this comment.
Same comment about comment being in wrong spot, or workaround not actually being needed.
There was a problem hiding this comment.
I ended up reordering them just in case
166b39a
|
@ros-pull-request-builder run tests please! |
Signed-off-by: methylDragon <methylDragon@gmail.com>
|
@ros-pull-request-builder retest this please! |
|
|
|
Merging since the only instabilities are viz |
See: #276
Linting
Migrates .h to .hpp
Pinging @svwilliams for visibility.