Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fuse viz crash #312

Merged
merged 2 commits into from
Jan 28, 2023
Merged

Fix fuse viz crash #312

merged 2 commits into from
Jan 28, 2023

Conversation

sloretz
Copy link
Collaborator

@sloretz sloretz commented Jan 28, 2023

Part of #276
Requires #311

This fixes a crash where Ogre's scene manager was being called with an empty name. I fixed it by using a different call for destroySceneNode that takes the pointer itself, and initializing pointers with nullptr.

@svwilliams FYI

@sloretz
Fix SerializedPublisher not being able to read it's parameters
082973d 
Signed-off-by: Shane Loretz <sloretz@google.com>
@sloretz
Fix crash of fuse_viz
04662c8 
Signed-off-by: Shane Loretz <sloretz@google.com>
@sloretz sloretz self-assigned this Jan 28, 2023
@methylDragon methylDragon merged commit 9e01285 into locusrobotics:rolling Jan 28, 2023
@methylDragon methylDragon mentioned this pull request Jan 28, 2023
Closed
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methylDragon methylDragon methylDragon approved these changes

Assignees

@sloretz sloretz

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sloretz @methylDragon