Use upstream rclcpp::node_interfaces::NodeInterfaces #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marked ready for review since ros/rosdistro#35993 @methylDragon would you be willing to give this a review? |
|
I think this will need a little bit more iteration, the nodeinterfaces implementation on rclcpp can't take in Node::SharedPtrs because of lack of support in RHEL.. So it'll require all instances of passing in a pointer to the node interfaces constructor to dereference that pointer... |
Signed-off-by: Shane Loretz <sloretz@google.com>
sloretz
force-pushed
the
sloretz__use_upstream_node_interfaces
branch
from
e27fe97
to
b9d916c
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #276
requires ros2/rclcpp#2094
This switches fuse to use the upstream
rclcpp::node_interfaces::NodeInterfaces. It will have to be merged later as upstream needs a default constructor to be usable here.@svwilliams FYI