fuse -> ROS 2 fuse_models: Linting #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methylDragon
force-pushed
the
rolling-models-linting
branch
2 times, most recently
from
9379686
to
cf7a114
Compare
54 tasks
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
rolling-models-linting
branch
from
cf7a114
to
c4800f2
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
|
Note @svwilliams : Two files had to get excluded from linting: e62784b This is because they featured copyright docstrings with proprietary copyrights. |
Signed-off-by: methylDragon <methylDragon@gmail.com>
sloretz
requested changes
Jan 29, 2023
| * 1. Creates relative or absolute orientation and constraints. If the \p differential parameter is | ||
| * set to false (the default), the orientation measurement will be treated as an absolute | ||
| * constraint. If it is set to true, consecutive measurements will be used to generate relative | ||
| * orientation constraints. 2. Creates 2D velocity variables and constraints. |
There was a problem hiding this comment.
nit, newline to keep list structure.
| * This sensor subscribes to a nav_msgs::msg::Odometry topic and: | ||
| * 1. Creates relative or absolute pose variables and constraints. If the \p differential parameter | ||
| * is set to false (the default), the measurement will be treated as an absolute constraint. If it | ||
| * is set to true, consecutive measurements will be used to generate relative pose constraints. 2. |
There was a problem hiding this comment.
same comment about new line to keep list structure.
| * velocity (array with x at index 0, y at index 1) 3 : vel_yaw1 - First | ||
| * yaw velocity 4 : acc_linear1 - First linear acceleration (array with x | ||
| * at index 0, y at index 1) 5 : position2 - Second position (array with x | ||
| * at index 0, y at index 1) 6 : yaw2 - Second yaw 7 : vel_linear2 - |
There was a problem hiding this comment.
Newlines to preserve list structure here
| // if (jacobians[i]) | ||
| // { | ||
| // Eigen::Map<fuse_core::Matrix<double, 8, ParameterDims::GetDim(i)>> jacobian(jacobians[i]); | ||
| // jacobian.applyOnTheLeft(-A_); } } |
There was a problem hiding this comment.
Newlines to preserve code example here
Signed-off-by: methylDragon <methylDragon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #276
Depends on: #314
Linting
Migrates .h to .hpp
Pinging @svwilliams for visibility.
Note: There's an open question about what to do about test_unicycle_2d.cpp and test_sensor_proc.cpp's proprietary copyright licenses (to fix ament_copyright)