New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Locust Helm Chart update #1210
Comments
Hi! Are you talking about this helm chart https://github.com/helm/charts/tree/master/stable/locust ? I think you should file a ticket with them instead :) |
@cyberw @bwcho75 As of there is no support for I would love to help you, make the pull-request and maintain that, if you need. |
I havent used helm enough to know if having the chart in our repo makes sense or not, but I dont see any problems with it. A PR would be most welcome! @heyman do you agree? |
@limakzi do you mean just committing the chart to this repo? Or do you mean setting up ChartMuseum and hosting a real helm repo for the locust chart? |
@max-rocket-internet I mean committing the chart into this repository or managing separate repository with Chart only. I do not see any good reason for managing ChartMuseum on our own, besides the state of the art.
Lets build the Helm Chart, push it here or create separate repository.
Both solutions are fine. 👍🏻 |
OK, makes sense.
It's a pain to use if you don't have a real chart repo as you can't do versioning of the chart and you need a local copy of this repo. But I guess it's still better than nothing.
I already maintain a locust chart here, it's already in the locust docs, you could start by just copying this chart. Up to you though 🙂 |
@max-rocket-internet Ouch, perfect! I haven't seen it before. Awesome job! I have reviewed this Chart and I would do some things a little bit different, but this is completely different discussion. |
Just copy it to this repo, update the |
@max-rocket-internet The question is, if we agree upon keeping |
Sorry, I don't understand this?
I am not a maintainer and cannot create repos under locustio org 🙂 |
@cgbystrom, @heyman Can we have a separate repository for Helm Chart? |
I've created a new repository at https://github.com/locustio/helm-chart. You should both have write access to it @limakzi and @max-rocket-internet Is locust/helm-chart a good name? Let me know if I should rename it to something else. |
@heyman |
So step 1 is to migrate the old Helm chart right? When that happens, it would be good to preserve the git history to some degree. Is that possible even though hashes would change etc because it would mean a rewritten history? +1 for helm chart btw |
Nice one @heyman
For which chart though? The old one from |
The old one was never an official one, and if the one you linked is better, I think we should use that one as the starting point (or maybe it's even fine to use as is?). My own experience with helm charts is very limited. |
OK here's an initial PR for the chart: locustio/helm-chart#1 |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This is fixed (thanks @max-rocket-internet) |
It kind of isn't fixed though, it's still waiting on @sekka1 to setup the chart artifacts/DNS part in locustio/helm-chart#2 |
Aha, I misunderstood... |
This issue was closed because it has been stalled for 10 days with no activity. |
bad bot |
@max-rocket-internet this kind dropped off my radar. What are you still waiting on me for? |
@sekka1 same as here: #1210 (comment) |
Ok...will take a look at this @max-rocket-internet |
@max-rocket-internet I kinda lost track of what is needed here. What is wrong with this still? |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
I dont think there is anything we need to do here. The chart is at https://github.com/deliveryhero/helm-charts/tree/master/stable/locust Any updates or issues are tracked in that project. |
Hello guys.
Thanx for developing great tools.
Locust can be leveraged by Helm over Kubernetes with easy install.
Unfortunately official helm chart for Locust is using Locust 0.9.0 image. I simply changed the image version to 0.13.5 but it didn't work. I suppose that there were some changes and the Helm chart needs to be updated followed by locust version up.
Could you please update the helm chart for recent version of locust?
Locust 0.9.0 seems to have different taskSet grammer etc
The text was updated successfully, but these errors were encountered: