Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locust Helm Chart update #1210

Closed
bwcho75 opened this issue Dec 27, 2019 · 29 comments
Closed

Locust Helm Chart update #1210

bwcho75 opened this issue Dec 27, 2019 · 29 comments
Labels
invalid stale Issue had no activity. Might still be worth fixing, but dont expect someone else to fix it waiting on contributor

Comments

@bwcho75
Copy link

bwcho75 commented Dec 27, 2019

Hello guys.
Thanx for developing great tools.
Locust can be leveraged by Helm over Kubernetes with easy install.
Unfortunately official helm chart for Locust is using Locust 0.9.0 image. I simply changed the image version to 0.13.5 but it didn't work. I suppose that there were some changes and the Helm chart needs to be updated followed by locust version up.
Could you please update the helm chart for recent version of locust?
Locust 0.9.0 seems to have different taskSet grammer etc

@cyberw
Copy link
Collaborator

cyberw commented Dec 29, 2019

Hi! Are you talking about this helm chart https://github.com/helm/charts/tree/master/stable/locust ?

I think you should file a ticket with them instead :)

@limakzi
Copy link

limakzi commented Dec 11, 2020

@cyberw @bwcho75 As of there is no support for charts/stable are you planning or need support with deploying Helm Chart in locustio organization?

I would love to help you, make the pull-request and maintain that, if you need.

@cyberw
Copy link
Collaborator

cyberw commented Dec 12, 2020

I havent used helm enough to know if having the chart in our repo makes sense or not, but I dont see any problems with it. A PR would be most welcome!

@heyman do you agree?

@max-rocket-internet
Copy link
Contributor

@limakzi do you mean just committing the chart to this repo? Or do you mean setting up ChartMuseum and hosting a real helm repo for the locust chart?

@limakzi
Copy link

limakzi commented Dec 17, 2020

@max-rocket-internet I mean committing the chart into this repository or managing separate repository with Chart only.

I do not see any good reason for managing ChartMuseum on our own, besides the state of the art.

  • More work to be done.
  • More difficult to maintain.

Lets build the Helm Chart, push it here or create separate repository.

Both solutions are fine. 👍🏻

@max-rocket-internet
Copy link
Contributor

I mean committing the chart into this repository or managing separate repository with Chart only

OK, makes sense.

I do not see any good reason for managing ChartMuseum on our own, besides the state of the art.

It's a pain to use if you don't have a real chart repo as you can't do versioning of the chart and you need a local copy of this repo. But I guess it's still better than nothing.

Lets build the Helm Chart

I already maintain a locust chart here, it's already in the locust docs, you could start by just copying this chart. Up to you though 🙂

@limakzi
Copy link

limakzi commented Dec 17, 2020

@max-rocket-internet Ouch, perfect! I haven't seen it before. Awesome job!
So, what I would change the owner, to make it kinda official.

I have reviewed this Chart and I would do some things a little bit different, but this is completely different discussion.

@max-rocket-internet
Copy link
Contributor

So, what I would change the owner, to make it kinda official.

Just copy it to this repo, update the Chart.yaml and then iterate changes in this repo I guess.

@limakzi
Copy link

limakzi commented Dec 19, 2020

@max-rocket-internet The question is, if we agree upon keeping index.yaml and tar.gz in Github repository.
If so, I will manage that; if not - please, create new repository with Chart only.

@max-rocket-internet
Copy link
Contributor

@limakzi

The question is, if we agree upon keeping index.yaml and tar.gz in Github repository.

Sorry, I don't understand this?

please, create new repository with Chart only.

I am not a maintainer and cannot create repos under locustio org 🙂

@limakzi
Copy link

limakzi commented Dec 22, 2020

@cgbystrom, @heyman Can we have a separate repository for Helm Chart?

@cyberw cyberw reopened this Dec 22, 2020
@heyman
Copy link
Member

heyman commented Jan 21, 2021

I've created a new repository at https://github.com/locustio/helm-chart. You should both have write access to it @limakzi and @max-rocket-internet

Is locust/helm-chart a good name? Let me know if I should rename it to something else.

@limakzi
Copy link

limakzi commented Jan 21, 2021

@heyman locust-chart looks perfect.
I will create pull request there.

@consideRatio
Copy link

consideRatio commented Jan 21, 2021

So step 1 is to migrate the old Helm chart right? When that happens, it would be good to preserve the git history to some degree. Is that possible even though hashes would change etc because it would mean a rewritten history?

+1 for helm chart btw

@max-rocket-internet
Copy link
Contributor

I've created a new repository at https://github.com/locustio/helm-chart. You should both have write access to it @limakzi and @max-rocket-internet

Nice one @heyman

I will create pull request there.
So step 1 is to migrate the old Helm chart right?

For which chart though? The old one from helm/charts/stable was pretty simplistic I think, also using an old random custom docker image. I think this one is better?

@heyman
Copy link
Member

heyman commented Jan 26, 2021

For which chart though? The old one from helm/charts/stable was pretty simplistic I think, also using an old random custom docker image. I think this one is better?

The old one was never an official one, and if the one you linked is better, I think we should use that one as the starting point (or maybe it's even fine to use as is?). My own experience with helm charts is very limited.

@max-rocket-internet
Copy link
Contributor

OK here's an initial PR for the chart: locustio/helm-chart#1

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale Issue had no activity. Might still be worth fixing, but dont expect someone else to fix it label Apr 11, 2021
@cyberw
Copy link
Collaborator

cyberw commented Apr 11, 2021

This is fixed (thanks @max-rocket-internet)

@cyberw cyberw closed this as completed Apr 11, 2021
@max-rocket-internet
Copy link
Contributor

It kind of isn't fixed though, it's still waiting on @sekka1 to setup the chart artifacts/DNS part in locustio/helm-chart#2

@cyberw
Copy link
Collaborator

cyberw commented Apr 15, 2021

Aha, I misunderstood...

@cyberw cyberw reopened this Apr 15, 2021
@github-actions
Copy link

This issue was closed because it has been stalled for 10 days with no activity.

@cyberw
Copy link
Collaborator

cyberw commented Apr 26, 2021

bad bot

@cyberw cyberw reopened this Apr 26, 2021
@cyberw cyberw removed the stale Issue had no activity. Might still be worth fixing, but dont expect someone else to fix it label Apr 26, 2021
@sekka1
Copy link

sekka1 commented Apr 26, 2021

@max-rocket-internet this kind dropped off my radar. What are you still waiting on me for?

@max-rocket-internet
Copy link
Contributor

@sekka1 same as here: #1210 (comment)

@sekka1
Copy link

sekka1 commented Apr 30, 2021

Ok...will take a look at this @max-rocket-internet

@sekka1
Copy link

sekka1 commented Jun 1, 2021

@max-rocket-internet I kinda lost track of what is needed here. What is wrong with this still?

@github-actions
Copy link

github-actions bot commented Aug 1, 2021

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale Issue had no activity. Might still be worth fixing, but dont expect someone else to fix it label Aug 1, 2021
@cyberw
Copy link
Collaborator

cyberw commented Aug 1, 2021

I dont think there is anything we need to do here. The chart is at https://github.com/deliveryhero/helm-charts/tree/master/stable/locust

Any updates or issues are tracked in that project.

@cyberw cyberw closed this as completed Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid stale Issue had no activity. Might still be worth fixing, but dont expect someone else to fix it waiting on contributor
Projects
None yet
Development

No branches or pull requests

7 participants