Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect "All users spawned" log messages when running distributed #1961

Closed
cyberw opened this issue Dec 17, 2021 · 4 comments
Closed

Incorrect "All users spawned" log messages when running distributed #1961

cyberw opened this issue Dec 17, 2021 · 4 comments
Labels
bug stale Issue had no activity. Might still be worth fixing, but dont expect someone else to fix it

Comments

@cyberw
Copy link
Collaborator

cyberw commented Dec 17, 2021

When running distributed, we print the wrong numbers, e.g.

All users spawned: {"UserSubclass": 2} (2 total users)

When the desired (and actual) final user count was 3.

Here's a test case that exhibits this (not 100% of the time, but almost) 4f7b37a

Maybe we are printing the numbers from the previous step, or we must wait until the next worker report comes in before printing? It seems to only happens with at least 5 workers (!?)

This issue seems to have been around for a while (maybe since 2.0)

@mboutet , do you have time to take a look?
@cyberw cyberw added the bug label Dec 17, 2021
@cyberw
Copy link
Collaborator Author

cyberw commented Dec 17, 2021

I did some additional testing and was able to reproduce with as few as one worker. Then the output is:

All users spawned: {} (0 total users)

@mboutet
Copy link
Contributor

mboutet commented Dec 19, 2021

I'll have time in January. I'll set a reminder on my side.

EzR1d3r added a commit to EzR1d3r/locust that referenced this issue Jan 23, 2022
@EzR1d3r
Fixing issue locustio#1961 with incorrect "All users spawned" log mes…
cbcb6c8 
…sages when running distributed by increasing wait time.

Now if the timeout of worker reports is expired, log the message about it.
@EzR1d3r EzR1d3r mentioned this issue Jan 23, 2022
Merged
EzR1d3r added a commit to EzR1d3r/locust that referenced this issue Jan 24, 2022
@EzR1d3r
Fixing issue locustio#1961 with incorrect "All users spawned" log mes…
4e20e02 
…sages when running distributed by increasing wait time.

Now if the timeout of worker reports is expired, log the message about it.
EzR1d3r added a commit to EzR1d3r/locust that referenced this issue Jan 24, 2022
@EzR1d3r
Fixing issue locustio#1961 with incorrect "All users spawned" log mes…
db48725 
…sages when running distributed by increasing wait time.

Now if the timeout of worker reports is expired, log the message about it.
EzR1d3r added a commit to EzR1d3r/locust that referenced this issue Jan 24, 2022
@EzR1d3r
Fixing issue locustio#1961 with incorrect "All users spawned" log mes…
7bfe320 
…sages when running distributed by increasing wait time.

Now if the timeout of worker reports is expired, log the message about it.
EzR1d3r added a commit to EzR1d3r/locust that referenced this issue Jan 26, 2022
@EzR1d3r
Fixing issue locustio#1961 with incorrect "All users spawned" log mes…
88ab6f9 
…sages when running distributed by increasing wait time.

Now if the timeout of worker reports is expired, log the message about it.
EzR1d3r added a commit to EzR1d3r/locust that referenced this issue Jan 26, 2022
@EzR1d3r
Fixing issue locustio#1961 with incorrect "All users spawned" log mes…
aa256cf 
…sages when running distributed by increasing wait time.

Now if the timeout of worker reports is expired, log the message about it.
EzR1d3r added a commit to EzR1d3r/locust that referenced this issue Jan 27, 2022
@EzR1d3r
Fixing issue locustio#1961 with incorrect "All users spawned" log mes…
4881841 
…sages when running distributed by increasing wait time.

Now if the timeout of worker reports is expired, log the message about it.
Also mock LOCUST_WAIT_FOR_WORKERS_REPORT_AFTER_RAMP_UP with old timeout in a test,
in another case would have to increase sleep timers in the test.
EzR1d3r added a commit to EzR1d3r/locust that referenced this issue Jan 27, 2022
@EzR1d3r
Fixing issue locustio#1961 with incorrect "All users spawned" log mes…
9fb91d4 
…sages when running distributed by increasing wait time.

Now if the timeout of worker reports is expired, log the message about it.
Also mock LOCUST_WAIT_FOR_WORKERS_REPORT_AFTER_RAMP_UP with old timeout in a test,
in another case would have to increase sleep timers in the test.
cyberw added a commit that referenced this issue Jan 28, 2022
@cyberw
Merge pull request #1977 from EzR1d3r/issue-1961-all-users-spawned-me…
48cee13 
…ssage-bug

Fixing issue #1961 with incorrect "All users spawned" log messages wh…
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale Issue had no activity. Might still be worth fixing, but dont expect someone else to fix it label Feb 18, 2022
@github-actions
Copy link

This issue was closed because it has been stalled for 10 days with no activity. This does not necessarily mean that the issue is bad, but it most likely means that nobody is willing to take the time to fix it. If you have found Locust useful, then consider contributing a fix yourself!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug stale Issue had no activity. Might still be worth fixing, but dont expect someone else to fix it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cyberw @mboutet