Allow multiple calls to response.failure() or response.success() within the same with block #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… using catch_response=True. The last call is what determines if the request is considered a success or failure. Add catch_response tests (for both HttpLocust's client and FastHttpLocust's client)
Codecov Report
@@ Coverage Diff @@
## master #1336 +/- ##
==========================================
+ Coverage 81.20% 81.21% +0.01%
==========================================
Files 24 24
Lines 2219 2231 +12
Branches 334 338 +4
==========================================
+ Hits 1802 1812 +10
+ Misses 331 329 -2
- Partials 86 90 +4
Continue to review full report at Codecov.
|
cyberw
reviewed
Apr 17, 2020
|
LGTM apart from that error message I didnt understand :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #1335