hardening Environment.shape_class for distinct usage #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does it fix that issue or just make it more clear if the user made a mistake? Looks like a reasonable change, I'm just wondering. And maybe it is meaningful to add a test case? |
|
Making it more clear, prevent usage error.
OK, I will add test case happily and rebase commit later. |
Hardening for issue 1981, make it more clear if the user made a mistake. Signed-off-by: Chenyang Yan <memory.yancy@gmail.com>
|
@cyberw I have updated and rebased it, you could be ready to review. |
|
thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardening for issue #1981, make it more clear if the user made a mistake.
Signed-off-by: Chenyang Yan memory.yancy@gmail.com