Add PERCENTILES_TO_CHART param in stats.py to make the Response Time Chart configurable#2313
Merged
Conversation
Percentiles were originally 50% and 95%. Command line parameter can specify chart and report percentiles. Defalt value is 50% and 95%.
Old parameters --percemtile1 and percentile2 were removed. Added test case in test_main for -percentiles parameter
cyberw
reviewed
Mar 4, 2023
cyberw
reviewed
Mar 4, 2023
Updated to get percentiles info from stats.py::
cyberw
reviewed
Mar 7, 2023
cyberw
reviewed
Mar 7, 2023
cyberw
reviewed
Mar 7, 2023
Collaborator
|
Once you're done, rename the PR to something more appropriate, now that we're not using a command line argument |
A1BOCO
changed the title
Collaborator
|
Nice. I think you accidentally commented out the import of pty in test_main.py. Ideally the test would actually check the UI to see that it took effect, but meh. Add it to the documentation at the bottom of docs/configuration.rst, and then we're pretty much done! |
Contributor
Author
|
I have corrected test_main.py and format of stats.py. Also update configuration.rst. Please review them. |
cyberw
reviewed
Mar 11, 2023
cyberw
reviewed
Mar 11, 2023
cyberw
reviewed
Mar 11, 2023
cyberw
reviewed
Mar 11, 2023
cyberw
reviewed
Mar 11, 2023
cyberw
reviewed
Mar 11, 2023
cyberw
reviewed
Mar 11, 2023
cyberw
reviewed
Mar 11, 2023
javascript and html file Modified test in test_main.py
cyberw
reviewed
Mar 12, 2023
response time chart
cyberw
reviewed
Mar 12, 2023
cyberw
reviewed
Mar 12, 2023
cyberw
reviewed
Mar 12, 2023
Collaborator
|
Nice! |
cyberw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added --percentiles command line argument which is for response time chart in chart page and download report page.
Default value is 95% and 50%.
example . # locust -f locust_file.py --percentiles 0.99,0.8
This is from issue #2311