Put dependencies/project information in pyproject.toml instead of setup.cfg (PEP621) #2336
Conversation
Add PEP621 format toml file
Add pep621_pyproject.toml * This TOML file complies with PEP517 & PEP518 & PEP621 This link is for the PYPI package generated by this TOML file. * https://pypi.org/project/locust-je-test-pep621/2.15.2.dev8/ I don't want to overwrite old pyproject.toml so i call this file pep621_pyproject.toml
Remove duplicate zip_safe
|
Nice. But go ahead and add it to pyproject.toml, otherwise it will not be tested before merging etc. We definitely dont want to have both at the same time. Is this compatible with Python 3.7 btw? You'll need to merge this with latest master to get the build working (because of this #2337) |
Pull #2337 and add pep621 to pyproject.toml
PEP621 allows pyproject.toml to generate the package on its own, but CI/CD requires setup.cfg so I didn't delete it.
|
Remove duplicate setuptools_scm on build system requires & old pyproject
from license = { file = "LICENSE"}
to license = { text = "MIT"}
because we have this options
license-files = ["LICENSE"]
Hm. If we'd have to maintain duplicate dependencies in setup.cfg I dont think this is worth it. |
Delete setup.cfg & setup.py
|
Look like we don't need setup.cfg & setup.py anymore what this test step do? |
|
That just ensures pip cache uniqueness. The cache is an optimization for faster (repeated) builds on GH. I think you can replace 'setup.cfg' with 'pyproject.toml' |
Replace 'setup.cfg' with 'pyproject.toml'
|
Makefile needs to be adjusted too, as this doesnt work anymore: |
…ist/* && python3 -m build . Replace rm -f dist/* && python3 setup.py sdist bdist_wheel to rm -f dist/* && python3 -m build .
|
While you are at it, you can nuke It contains a reference to setup.py which will stop working now. And the file hasnt been updated in 11 (!) years :) |
|
Hmm... |
|
We need "pip install --upgrade build" first |
Yea, I was in a virtualenv and forgot to install it. Oops. Do you wanna remove vagrant.sh or should I? |
Nuke examples\vagrant\vagrant.sh and add pip upgrade build on Makefile
cyberw
changed the title
|
Good stuff, thanks! |
cyberw
changed the title
Add pep621_pyproject.toml
This link is for the PYPI package generated by this TOML file.
I don't want to overwrite old pyproject.toml so i call this file pep621_pyproject.toml
PEP621