Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the users dispatching when it got infinite loop (fixes #2345) #2350

Merged
merged 1 commit into from
May 29, 2023

Conversation

EzR1d3r
Copy link
Contributor

@EzR1d3r EzR1d3r commented May 22, 2023

I currently do not have not a local configured unittests, so this is WIP MR for checks.

@EzR1d3r EzR1d3r force-pushed the issue-2345 branch 3 times, most recently from 99d0061 to b3be296 Compare May 28, 2023 12:36
@EzR1d3r EzR1d3r changed the title WIP: fix issue-2345 (temporary MR for unittest check) Fix issue-2345 May 28, 2023
@EzR1d3r EzR1d3r marked this pull request as ready for review May 28, 2023 12:49
@cyberw
Copy link
Collaborator

cyberw commented May 28, 2023

Nice! Whats a good title for the PR? Something like ”Fix problem with fixed_count in combination with LoadShapes”?

@EzR1d3r EzR1d3r changed the title Fix issue-2345 Fixed the users dispatching when it got infinite loop (issue-2345) May 29, 2023
In some rare cases the dispatch function stucks in an infinite loop.
So fixed the bug and added unit tests.
@EzR1d3r
Copy link
Contributor Author

EzR1d3r commented May 29, 2023

Nice! Whats a good title for the PR? Something like ”Fix problem with fixed_count in combination with LoadShapes”?

Done. =)

@cyberw cyberw merged commit 7002fb7 into locustio:master May 29, 2023
12 checks passed
@cyberw
Copy link
Collaborator

cyberw commented May 29, 2023

👍 thx!

@cyberw cyberw changed the title Fixed the users dispatching when it got infinite loop (issue-2345) Fixed the users dispatching when it got infinite loop (fixes #2345) May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants