Fix #1910 KeyboardInterrupt with load shapes #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please let me know if any other tests need to be written. This is my first Pull Request on an Open Source Project 😃. |
cyberw
changed the title
cyberw
changed the title
|
Thanks! I dont think the flake8 issue is your fault so you can ignore it. In the test, I think you should send the interrupt signal from the test rather than throwing an exception from inside the locustfile. Can you change that? There are some other tests like that in test_main.py |
|
Nice! For future contributions, use I'll squash your commits when merging so I can edit the messages :) I'll fix the flake8 issue in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be honest this is probably more of a bandaid solution, but for dealing with
KeyboardInterruptthis is hopefully sufficient. I've added an integration test that raises aKeyboardInterrupt. The logic being that if properly handled, the test will end properly,@events.test_stop.add_listenerwill execute, and a report will be generated.