DeprecationWarning: the load_module() method is deprecated and slated for removal in Python 3.12; use exec_module() instead - #2576
Merged
Conversation
instead of `load_module`, which is deprecated and was planned to be removed in 3.12.
Collaborator
|
Awesome. I've been annoyed by this for a long time. Will sure to merge this once the modern-UI-default is released. |
cyberw
added a commit
that referenced
this pull request
Feb 6, 2024
…odule during import, but it can be worked around (this used to work before #2576)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the unit tests and looking at the output, the
DeprecationWarningin the title is thrown/visible a couple of times.In python 3.4
load_modulewas replaced withexec_module. [0][1]The tests does indeed work on 3.12, so seems like it hasn't been removed yet,
but this PR replaces the call to
load_moduleinlocust.util.load_locustfile.load_locustfileto useexec_moduleinstead.[0] https://peps.python.org/pep-0451/
[1] https://docs.python.org/3/library/importlib.html#importlib.abc.Loader.load_module