pluggable dispatcher logic #2606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eating Environment
|
Idk, this still changes/adds a lot of code.... Could you just subclass UsersDispatcher and override its methods insteas of introducing an abstract base class? (and not rename the methods. tbh I'm not sure about the reasoning for making them all private (_ prefix) but I'd rather not change it) I understand it is not the cleanest OO-principles to do that, but low complexity in locust core is more important. |
|
sure, update with the only change in changed the PR to a draft, since I'd like to test them out in our project first, which uses the branch in my fork that this PR also is based on. |
|
nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
superseeding #2568, coming from discussion in #2522.
this PR makes it possible to implement custom dispatcher logic and specifying the dispatcher class when creating an
Environment.a little unsure and not really satisfied with the name of the "interface"
UserDispatcherType.played around with
UserDispatcherBase(but it's discouragedto useBase).IUserDispatcherdoesn't feel pythonic. so any suggestion on a better name is welcomed :) my top choice would be to renameUserDispatchertoWeightedUserDispatcher(or similar) and have the interface changed toUserDispatcher, but at the same time I wanted to make as few changes as possible.some methods and properties in the interface was added to make it easier to [compability] test implementations.
so minor changes in the current dispatcher logic so it uses the interface specified methods and properties.