Remove test dependency unittest2 #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As locust no longer support Python 2.6, there is no need to install unittest2. The unittest shipped with the Python 2.7+ stdlib is the same as unittest2. Results in fewer dependencies and slightly faster installation during testing. Python support was removed in version 0.8.
cgoldberg
approved these changes
Mar 23, 2018
Codecov Report
@@ Coverage Diff @@
## master #755 +/- ##
=======================================
Coverage 65.13% 65.13%
=======================================
Files 14 14
Lines 1417 1417
Branches 222 222
=======================================
Hits 923 923
Misses 443 443
Partials 51 51Continue to review full report at Codecov.
|
|
@jdufresne thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As locust no longer support Python 2.6, there is no need to install unittest2. The unittest shipped with the Python 2.7+ stdlib is the same as unittest2.
Results in fewer dependencies and slightly faster installation during testing.
Python 2.6 support was removed in version 0.8.