Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct fail ratio calculation. Fixes #991. #994

Merged
merged 1 commit into from Apr 7, 2019
Merged

Correct fail ratio calculation. Fixes #991. #994

merged 1 commit into from Apr 7, 2019

Conversation

genericmoniker
Copy link
Contributor

No description provided.

cgoldberg
cgoldberg approved these changes Apr 7, 2019
View reviewed changes
Copy link
Member

@cgoldberg cgoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM... thanks for including a test!

@cgoldberg cgoldberg merged commit ed542b0 into locustio:master Apr 7, 2019
@aldenpeterson-wf aldenpeterson-wf mentioned this pull request May 9, 2019
Closed
@rahim04a4
Copy link

Still the same issue is present. I have a doubt like which purpose we are using test_stats ?
we are using same for fail ratio?
def test_fail_ratio_with_failures(self):
s = StatsEntry(self.stats, "/", "GET")
s.num_requests = 10
s.num_failures = 5
self.assertAlmostEqual(s.fail_ratio, 0.5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgoldberg cgoldberg cgoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@genericmoniker @rahim04a4 @cgoldberg