Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch CVE-2020-13619 #426

Merged
merged 5 commits into from Oct 2, 2020
Merged

patch CVE-2020-13619 #426

merged 5 commits into from Oct 2, 2020

Conversation

divinity76
Copy link
Contributor

@divinity76 divinity76 commented Sep 22, 2020

fixes #420

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

see #420

(also it's technically possible to create a smaller command with the same data, \'\' and ''\'''\''' compiles to the exact same string, but given the security-sensitive aspect if we get the optimization wrong, and the fact that even the php core developers didn't try to optimize this part, we probably shouldn't try to do that either. i suspect it was such an optimization gone wrong that lead to CVE-2020-13619 in the first place.)

@kvz kvz merged commit a05e9e7 into locutusjs:master Oct 2, 2020
@kvz
Copy link
Collaborator

kvz commented Oct 2, 2020

Thank you! Merged and released as locutus@2.0.13

@divinity76
Copy link
Contributor Author

@kvz thanks,

and while i got your attention, know that PR #425 and PR #424 is about the same function, but separate issues to this PR, and not withdrawn ^^

@kvz
Copy link
Collaborator

kvz commented Oct 2, 2020

Appreciated, will check them out 👍

@divinity76
Copy link
Contributor Author

https://locutus.io/php/exec/escapeshellarg/ still displays the vulnerable version, can someone fix that?

ping @kvz wouldn't surprise me if you're the web admin

@kvz
Copy link
Collaborator

kvz commented Nov 19, 2020

Hey, thanks, I fixed some issues and the website should be updated

@divinity76
Copy link
Contributor Author

divinity76 commented Nov 19, 2020

@kvz hmm, at 2020-11-19T15:09:19+00:00 it's still displaying the vulnerable version
image

@kvz
Copy link
Collaborator

kvz commented Nov 19, 2020

Ah thanks for catching, fixed for real now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote Code Execution vulnerability
2 participants