Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs broken on Firefox #48

Closed
zackhall opened this issue Sep 2, 2016 · 4 comments
Closed

Docs broken on Firefox #48

zackhall opened this issue Sep 2, 2016 · 4 comments
Labels
bug

Comments

@zackhall
Copy link
Contributor

zackhall commented Sep 2, 2016

The list of functions in the TOC container has all empty HTML elements (no method name) on Firefox...

image
@zackhall
Copy link
Contributor Author

zackhall commented Sep 2, 2016 •
edited

Seems like it could be related to the Immutable JS change.

Line 163:

collection.get('title') //undefined

@jdalton
Copy link
Member

jdalton commented Sep 2, 2016 •
edited

What version of Firefox are you on?

FF48:

@zackhall
Copy link
Contributor Author

zackhall commented Sep 2, 2016

Yeah, you're right. My Firefox was still on 42... Updated and is working okay again.

@zackhall zackhall closed this as completed Sep 2, 2016
@jdalton jdalton added the invalid label Sep 2, 2016
@jdalton jdalton mentioned this issue Sep 2, 2016
Closed
@jdalton
Copy link
Member

jdalton commented Sep 3, 2016

This is because Firefox added innerText support in 45.

jdalton added a commit that referenced this issue Sep 3, 2016
@jdalton
Use textContent where possible. [closes #48, #51]
f5888f2
@jdalton jdalton added bug and removed invalid labels Sep 3, 2016
jdalton added a commit that referenced this issue Sep 3, 2016
@jdalton
Use textContent where possible. [closes #48, #51]
f79349c
jdalton added a commit that referenced this issue Sep 3, 2016
@jdalton
Use textContent where possible. [closes #48, #51]
e8ced53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdalton @zackhall