Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the internal toPath method #1365

Closed
w33ble opened this issue Jul 23, 2015 · 3 comments
Closed

Expose the internal toPath method #1365

w33ble opened this issue Jul 23, 2015 · 3 comments
Labels
question

Comments

@w33ble
Copy link

w33ble commented Jul 23, 2015

I'm building a module that makes a lot of use of _.get and _.set internally, and I keep finding myself wishing I had access to toPath, the method that turns a string path into an array. I don't even need new functionality, I'd just like it to be exposed externally, via _.toPath or something.

I'm happy to make a PR for it but wanted to open an issue in case there's some opposition to exposing it.
@jdalton
Copy link
Member

jdalton commented Jul 23, 2015

Good news @w33ble! You can do require('lodash/internal/toPath').

@jdalton jdalton closed this as completed Jul 23, 2015
@w33ble
Copy link
Author

w33ble commented Jul 24, 2015

Oh, sorry, I didn't realize the internal methods were all modularized as well. Thank you!!

w33ble added a commit to w33ble/kibana that referenced this issue Aug 26, 2015
@w33ble
remove the toPath method, use lodash internals
ee3b242 
internal lodash methods are exposed as individual modules, see lodash/lodash#1365
w33ble added a commit to w33ble/kibana that referenced this issue Oct 19, 2015
@w33ble
remove the toPath method, use lodash internals
e2bb545 
internal lodash methods are exposed as individual modules, see lodash/lodash#1365
@lock
Copy link

lock bot commented Jan 20, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
question
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdalton @w33ble