Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split breaks up 🏴󠁧󠁢󠁷󠁬󠁳󠁿 #5652

Closed
Johennes opened this issue May 23, 2023 · 4 comments
Closed

split breaks up 🏴󠁧󠁢󠁷󠁬󠁳󠁿 #5652

Johennes opened this issue May 23, 2023 · 4 comments
Labels
issue bankruptcy Closing the issue/PR to start fresh

Comments

@Johennes
Copy link

This passes:

it('should not split 🇩🇪', function() {
  var wrapped = _('a🇩🇪b');
  assert.strictEqual(wrapped.split('').join(','), 'a,🇩🇪,b');
});

This doesn't:

it('should not split 🏴󠁧󠁢󠁷󠁬󠁳󠁿', function() {
  var wrapped = _('a🏴󠁧󠁢󠁷󠁬󠁳󠁿b');
  assert.strictEqual(wrapped.split('').join(','), 'a,🏴󠁧󠁢󠁷󠁬󠁳󠁿,b');
});
  1 failing

  1) split
       should not split 🏴󠁧󠁢󠁷󠁬󠁳󠁿:

      AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected

+ 'a,🏴,󠁧,󠁢,󠁷,󠁬,󠁳,󠁿,b'
- 'a,🏴󠁧󠁢󠁷󠁬󠁳󠁿,b'
       ^
      + expected - actual

      -a,🏴,󠁧,󠁢,󠁷,󠁬,󠁳,󠁿,b
      +a,🏴󠁧󠁢󠁷󠁬󠁳󠁿,b

Downstream issue: element-hq/element-web#22196

@justjanne

This comment was marked as outdated.

@t3chguy
Copy link

t3chguy commented May 24, 2023

@t3chguy
Copy link

t3chguy commented Sep 16, 2023

@jdalton can you link to what fixed this issue? What version is it fixed it? Are there regression tests?

@jdalton
Copy link
Member

jdalton commented Sep 16, 2023

@t3chguy Issue bankruptcy. Working on v5 with fresh eyes after a few years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue bankruptcy Closing the issue/PR to start fresh
Development

No branches or pull requests

4 participants