RangeError: Maximum call stack size exceeded

[mgcrea]

Probably not a bug but I got some weird error after upgrading from ~v2.4, haven't really dug into yet but it might help anyone encountering this suddenly:

Using a "standard" _.defaultsDeep like this (eg. like merge-defaults):

var defaultsDeep = _.partialRight(_.merge, function deep(value, other) {
  if (_.isArray(value) || _.isDate(other)) return value;
  return _.merge(value, other, deep);
});

This is now crashing with RangeError: Maximum call stack size exceeded:

defaultsDeep('{,modules/*/}{views,scripts,modules}/**/*.{jade,html}', '{views,modules/*}/**/*.{html,jade}');

Somehow the _.merge gets stuck on merging the { char, Haven't found something that could explain this by reading the changelog yet.

Worked in the v2.4 branch.

[jdalton]

Yap, many recursive methods are susceptible to call stack limits which vary for enviros and func too size. It's not a common enough problem to address at the moment (would mean large perf hits for an edge issue)

[jdalton]

@mgcrea can you gist the object your iterating over.

[mgcrea]

@jdalton https://gist.github.com/mgcrea/523ef0ea0b37ee9b330b

Fixed it with this for now, looks like to be working:

var defaultsDeep = _.partialRight(_.merge, function deep(value, other) {
  if (_.isString(value) || _.isArray(value) || _.isDate(other)) return value;
  return _.merge(value, other, deep);
});

[edit] Might be more reusable as JSONs https://gist.github.com/mgcrea/5881666f7c71280b758c

[jdalton]

These objects are tiiiiny. I'll dig in this evening.

[mgcrea]

@jdalton

Indeed, the base test-case does crash and is only merging two strings:

defaultsDeep('{,modules/*/}{views,scripts,modules}/**/*.{jade,html}', '{views,modules/*}/**/*.{html,jade}');

Might help:

$ node --version
v0.10.35
$ uname -a
Darwin 0x6D67 14.1.0 Darwin Kernel Version 14.1.0: Mon Dec 22 23:10:38 PST 2014; root:xnu-2782.10.72~2/RELEASE_X86_64 x86_64 i386 MacBookPro11,3 Darwin

[jdalton]

The method isn't intended for strings so I think its probably iterating them as a string object (so iterating the index proprerties of both strings)

[jdalton]

This is a bug on _.merge handling of string values.

[jdalton]

Added tests 89ed40e.

[recurrence]

Ran into this as well with a defaultsDeep implementation when upgrading from 2.4.1 to 3.2.

[jdalton]

Expect a bump, 3.3.0, by Friday evening.

[recurrence]

Thanks!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.