Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape the backtick in escape description #1008

Merged
merged 1 commit into from Feb 27, 2015
Merged

Escape the backtick in escape description #1008

merged 1 commit into from Feb 27, 2015

Conversation

mohsen1
Copy link
Contributor

@mohsen1 mohsen1 commented Feb 27, 2015

Noticed this little odd rendering in API docs

@jdalton
Copy link
Member

jdalton commented Feb 27, 2015

Thanks, all you have to do is escape the ```in '\`' hmm.

@mohsen1
Copy link
Contributor Author

mohsen1 commented Feb 27, 2015

I noticed other methods don't wrap characters between backticks, but I'm not sure how it's possible to escape a backtick when it's not a inline code block.

This is another way of doing it:

Converts the characters "&", "<", ">", '"', "'", and "```", in string to

@jdalton
Copy link
Member

jdalton commented Feb 27, 2015

Converts the characters "&", "<", ">", '"', "'", and "`", in string to

Let's go that route. I've fixed this on site.

@mohsen1
Copy link
Contributor Author

mohsen1 commented Feb 27, 2015

Updated the commit with that

@jdalton
Copy link
Member

jdalton commented Feb 27, 2015

Have you signed our CLA?

@jdalton
Copy link
Member

jdalton commented Feb 27, 2015

Actually, on second look simply escaping with ` works. Maybe not in github comments but in markdown in general. See https://gist.github.com/jdalton/985387ddf9fd4e67cd21

@mohsen1
Copy link
Contributor Author

mohsen1 commented Feb 27, 2015

signed the CLA (submitted a CLA on 2015-02-27 21:53:03) and updated the commit.
I didn't know backslash escaping works in Markdown. Good to know!

jdalton added a commit that referenced this pull request Feb 27, 2015
Escape the backtick in `_.escape` docs. [ci skip]
@jdalton jdalton merged commit 2795692 into lodash:master Feb 27, 2015
@lock
Copy link

lock bot commented Dec 27, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants