Add String to valid includes parameters [ci skip] #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5990,7 +5990,7 @@ | |||
| * @static | |||
| * @memberOf _ | |||
| * @category Collection | |||
| * @param {Array|Object} collection The collection to search. | |||
| * @param {Array|Object|String} collection The collection to search. | |||
There was a problem hiding this comment.
I have this in my local lol. Make the String -> string and it's good to go.
There was a problem hiding this comment.
Whoopsies, always forget those jsdoc semantics
jdalton
added a commit
that referenced
this pull request
Jul 20, 2015
Add String to valid includes parameters. [ci skip]
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is still an example for includes with a string, as discussed in gitter this should be here if the behaviour is sticking around