Expose lodash to node-webkit

[jawb]

No description provided.

[jdalton]

I'm all for added support.
@jawb can you explain what the issue is, why the patch is done the way it is, and sign the cla.

[jawb]

in node-webkit lodash is not exposed, I modified the condition

[jdalton]

On further review I believe this is a dup of #363.

[jawb]

The problem is not when using require but when including _ using script tag.

[jdalton]

Based on the usage examples it looks like using the script tag is not what's promoted. Use the node require syntax for this.

[jawb]

Yeah, but I don't generate the .nw every time I just use script tag to use refresh and make testing easier

[jdalton]

If I modified our exports then it would break the common usage for node-webkit. For your needs you could run the custom build tool to specify that you only want to export to the global via:

lodash mobile exports=global

[jawb]

Sure, that's a good solution

[tomasdev]

👍 is there a way to make whatever exports=global does, without breaking anything, for the regular builds?

I mean, it took me 2hs to finally find this post, could be nice to have it integrated in the next version :P

[terinjokes]

@tomasdev Not that I know of. Including exports=global in the build means the output only have the global export option, whereas the regular build has exports for Node/CommonJS, AMD and then global.

[tomasdev]

Then I would consider this as an issue for webkit-node where the "automatic switching context" of V8 is not doing its job properly.

BTW, I think we could do ifs instead of if-elses

[tomasdev]

Also, using the UnderscoreJS library doesn't trigger this error, so I guess the fix needs to be part of the "as drop in of underscore replacement" version.

[jdalton]

@tomasdev Thanks. I dug in a bit more and found that jQuery and Underscore work without issue so I hammered on it a bit and fixed it so Lo-Dash works out of the box with node-webkit too 😀

[terinjokes]

@jdalton Nice.

[tomasdev]

Yay!! Open source FTW. Thank you very much.

[jasonfutch]

Where would that file be? The ones on the website still don't work but underscore does.

[jdalton]

@jasonfutch
It will be available on cdns & our site on the next version bump.
You can get edge versions of the files atm here:
https://github.com/lodash/lodash/tree/master/dist

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.