Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not pass the initial arguments along with the flow #4912

Closed
wants to merge 1 commit into from

Conversation

theguriev
Copy link

@theguriev theguriev commented Aug 29, 2020

Hey 馃槆

// Now this example will not work because arguments not passing along the flow
const addOne = (num) => num + 1
const isDuplicate  = (current, index, array) => array.includes(current) // Array is undefined which is unlogical
const allFuncs = flow(addOne, isDuplicate)
[1, 2, 3].map(allFuncs)

Please review this.
Thank you! 馃槆

@jsf-clabot
Copy link

jsf-clabot commented Aug 29, 2020

CLA assistant check
All committers have signed the CLA.

@theguriev
Copy link
Author

@Chantouch Can u review that, please? It would be cool to have it inside the lodash because now I'm using my own solution.

@Chantouch
Copy link

@Chantouch Can u review that, please? It would be cool to have it inside the lodash because now I'm using my own solution.

@gcofficial why me ? lol

@theguriev
Copy link
Author

@Chantouch Can u review that, please? It would be cool to have it inside the lodash because now I'm using my own solution.

@gcofficial why me ? lol

Sorry, I thought that you should review that. 馃槆 Do you know who it should be?
Who can review it and merge?

@Chantouch
Copy link

@Chantouch Can u review that, please? It would be cool to have it inside the lodash because now I'm using my own solution.

@gcofficial why me ? lol

Sorry, I thought that you should review that. 馃槆 Do you know who it should be?
Who can review it and merge?

Hmmm, just the owner of repo or who have authorized to review and merge .

@theguriev
Copy link
Author

@Chantouch Thx man. And sorry. I thought you have that.

@jdalton Can u review that plz?

@theguriev
Copy link
Author

@bnjmnt4n Maybe u can review it and merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue bankruptcy Closing the issue/PR to start fresh
Development

Successfully merging this pull request may close these issues.

None yet

4 participants