Add Latin Extended-B and Latin Extended Additional to deburr #5491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Latin Extended-B and Latin Extended Additional Unicode blocks. Currently, the deburr function is missing support for a lot of commonly used characters. This means that, for example, in Romanian, the word "cățărat" will be deburred into "cațarat". This behavior is inconsistent and confusing to the user.
This problem is not limited to Romanian — I saw multiple requests 1234 for characters in various blocks, and so I think the community would welcome this addition.
Because not all characters have Latin equivalents, I have attached lists of the characters I did not include, from both the Latin Extended-B 5 and Latin Extended Additional 6 blocks. The characters I selected for deburring either have clear diacritics which can be "removed", or otherwise have a very clear equivalent Latin character.
Please note that I was not able to sign the CLA, as the linked CLA page states "There is no CLA to sign for lodash/lodash", with an error about authorization tokens.
Footnotes
https://github.com/lodash/lodash/issues/5251 ↩
https://github.com/lodash/lodash/issues/4530 ↩
https://github.com/lodash/lodash/issues/3836 ↩
https://github.com/lodash/lodash/issues/5363 ↩
https://paste.sr.ht/~alexandru_miricioiu/9c9cb0db922afeeee88a026ff73ea36f324fa068 ↩
https://paste.sr.ht/~alexandru_miricioiu/9e3ef083a10ba48fd0e2c402bb96113750891fca ↩