Improve to-many relations #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a little bug and then we should be good. The https://github.com/lode/jsonapi/blob/master/src/response.php#L173 //unset($resource_array['relationships'], $resource_array['meta']);
$this->included_resources = array_merge($this->included_resources, $resource->included_resources);if we comment the And have an Output JSON Like this https://gist.github.com/Pierozi/6361d7f80d6379df472b |
|
I'm sorry it took so long, but fyi, I'm going to merge and release this PR. I added a separate issue for the bug you noted, as it is not a change from this PR. I plan to pick it up directly though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #3 and fixes some issues raised there.