Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

リアルタイムプレビューを実装 #174

Closed
wants to merge 23 commits into from
Closed

リアルタイムプレビューを実装 #174

wants to merge 23 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 28, 2016

  • browserify-railsとreact-rails、npmを導入
  • React.jsでEditorを書き換え
  • 入力したMarkdownは1000ミリ秒ごとにプレビュー
  • Markdownパーサは既存のQiita::Markdownを踏襲
  • localでrspecが通ることを確認
  • レイアウトは現状維持

@coveralls
Copy link

Coverage Status

Coverage decreased (-8.6%) to 55.161% when pulling ab74312 on huggys:realtime-preview into d903de4 on lodge:develop.

@m-yamashita
Copy link
Member

多数のfixありがとうございます！
すみません、現在大変余裕がないため、後日確認させていただきますので、しばらくお待ちください 🙇

@coveralls
Copy link

Coverage Status

Coverage decreased (-8.6%) to 55.161% when pulling 9b6b326 on huggys:realtime-preview into d903de4 on lodge:develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-7.4%) to 56.345% when pulling 9b6b326 on huggys:realtime-preview into d903de4 on lodge:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 63.841% when pulling 1517021 on huggys:realtime-preview into d903de4 on lodge:develop.

@ghost
Copy link
Author

ghost commented Mar 29, 2016

Ruby 2.1系でTravis CIが通るように修正しました。

@m-yamashita
Copy link
Member

@uknmr 本PRのブランチに対して、 #97 の内容をとり込んだものをPRさせていただきました。
お手数ですがご確認ください 🙇

uknmr added 21 commits April 21, 2016 23:24
@uknmr
Declare 'shoulda-matchers' version.
0eedde2 
rspecが動作しなかったため、shoulda-matchersのバージョンを固定した。
またShoulda::Matchers.configureも追加した。
@uknmr
Add 'react-rails' ~> 1.6.0
b1f6035
@uknmr
Generate react:install
1c14a60
@uknmr
Add 'browserify-rails'
02b3852
@uknmr
Add modules for 'browserify-rails' and 'babelify'
b5c0865
@uknmr
Add Editor component
1240720
@uknmr
Replace markdown-editor with 'Editor' component
a416930
@uknmr
Fix markdown-editor style
47e71a5
@uknmr
Remove useless code
ecb900d
@uknmr
Refactor Editor component to include Stateless component
02ab386
@uknmr
Add axios 0.9.1
67e32d5
@uknmr
Replace markdown parser with qiita-markdown
66233cf
@uknmr
Add lodash.throttle 4.0.1
8a76ab4
@uknmr
Improve auto-preview to throttled
b92b946
@uknmr
Replace html_safe with '<%== %>'.
91054fb 
Rails Guideで推奨されていたため。
http://guides.rubyonrails.org/active_support_core_extensions.html#output-safety
@uknmr
Refactor assets initializer
ebcd9c3
@uknmr
Improve automaticly match the height to preview area.
e153714 
Sass 3.3以降の&を使いたかったが、assets:precompile周りを解決できなかった
ためベタ書きした。
@uknmr
Fix mouseup event outside browser
9aa167a
@uknmr
🚮
a2cbb98
@uknmr
Update travis-ci config for npm.
ae2b760 
- npm installを追加
- assets:precompileを追加
- TravisのPhantomjsが2系を使うようにscriptを追加
- bundlerやassets:precompileをcacheするように設定
@uknmr
Fix Capybara::Poltergeist::MouseEventFailed.
669d9a8 
https://github.com/teampoltergeist/poltergeist#mouseeventfailed-errors
@coveralls
Copy link

coveralls commented Apr 21, 2016 •
edited

Coverage Status

Coverage increased (+0.5%) to 64.676% when pulling 669d9a8 on huggys:realtime-preview into c3c42ed on lodge:develop.

@ghost
Copy link
Author

ghost commented Apr 21, 2016

@m-yamashita PRありがとうございました。rebaseしました！

m-yamashita
m-yamashita reviewed May 1, 2016
View reviewed changes
spec/rails_helper.rb
@@ -95,3 +95,10 @@
with.library :rails
end
end

Shoulda::Matchers.configure do |config|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません、こちらrebaseによりすぐ上の定義と被ってしまっているので削除していただけますか？

@coveralls
Copy link

coveralls commented May 1, 2016 •
edited

Coverage Status

Coverage increased (+0.1%) to 64.334% when pulling 132e60e on huggys:realtime-preview into c3c42ed on lodge:develop.

@m-yamashita
Copy link
Member

README.mdに npm install などの手順が必要となると思いますので、そのあたりも追記していただければと思います。

@ghost
Copy link
Author

ghost commented May 4, 2016

指摘ありがとうございます。
README.mdを更新しました。

@coveralls
Copy link

coveralls commented May 4, 2016 •
edited

Coverage Status

Coverage increased (+0.1%) to 64.334% when pulling 3937bec on huggys:realtime-preview into c3c42ed on lodge:develop.

@ghost ghost closed this Dec 7, 2016
@ghost ghost deleted the realtime-preview branch December 7, 2016 15:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coveralls @m-yamashita @uknmr