letter_openerの追加 #64
Merged
letter_openerの追加 #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -56,18 +56,8 @@ | |||
| # Devise Settings | |||
| # 以下は主にユーザのパスワード忘れの際のメール送信で利用する設定です。 | |||
|
|
|||
| config.action_mailer.delivery_method = :letter_opener | |||
There was a problem hiding this comment.
63行目の ENV["DELIVERY_METHOD"] を使うようにしていただけないでしょうか。
また、 64行目以降の削除も、 development の状態で使用したい場合に困る可能性がありますので、
削除しないでいただきたいです（残しておいても :sendmail の場合と同様、無視されるかと考えておりますが、あっていますでしょうか？）
https://github.com/lodge/lodge/blob/develop/.env.example に :letter_opener の場合の説明を追記していただくのが良いかと思います。
There was a problem hiding this comment.
83393d2 修正しました。今まで、ローカルでSMTPを使いたいというシーンが無かったので、消していました。
comuttun
added a commit
that referenced
this pull request
Jul 18, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
会社での導入を検討しているので、developmentはSMTPを介したくないのでletter_openerに変更しました。
取り込みを検討して頂けると助かります。