-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support django >= 2.2.17 < 3 #21
Conversation
…sistent with graphene (Issue graphql-python#1316)
setup.py
Outdated
@@ -10,7 +10,7 @@ | |||
ast.literal_eval(_version_re.search(f.read().decode("utf-8")).group(1)) | |||
) | |||
|
|||
rest_framework_require = ["djangorestframework>=3.6.3"] | |||
rest_framework_require = ["djangorestframework == 3.13.1"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi - only version supporting both 2.2 and 4,x
@@ -20,7 +20,7 @@ | |||
"coveralls", | |||
"mock", | |||
"pytz", | |||
"django-filter>=22.1", | |||
"django-filter>=2.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi - support from 2.2 to 4 django
e2169de
to
2e60c40
Compare
2e60c40
to
6eae245
Compare
@@ -26,6 +28,7 @@ setenv = | |||
deps = | |||
-e.[test] | |||
psycopg2-binary | |||
django22: Django>=2.2.17,<3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi - doesn't support python 3.9 below 2.2.17 and both GSC and SO are above that one.
b7960dd
to
d3b07cb
Compare
d3b07cb
to
a390371
Compare
I wasn't successful in debugging that failed test. It was passing before without much change to the branch. |
On hold because the end use case in my organization (upgrade of a micro-service to graphene v3) with django 2 is on hold. |
b8c09fa
to
41cac6d
Compare
b5eb40d
to
a3e4459
Compare
Main change
Add support to django 2.2
Loft Internal: pre-requisite for migration of django 2 services to graphene v3
Other changes
I had to batch replace py.test by pytest for make tests to pass locally. :