New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing quotes for hosts #31

Merged

FabianKramm merged 1 commit into loft-sh:master from WilliamDASILVA:patch-1

Jan 4, 2021

Contributor

WilliamDASILVA commented Dec 21, 2020 •

edited

Since hosts can have special characters "*.my-domain.tld", it must be quoted, otherwise getting an error:

[fatal]  Error deploying api: Unable to deploy helm chart: YAML parse error on component-chart/templates/ingress.yaml: error converting YAML to JSON: yaml: line 33: did not find expected alphabetic or numeric character

fixes #32


          fix: add missing quotes for host

6ea227d

Since hosts can have special characters "*.my-domain.tld", it must be quoted.

WilliamDASILVA mentioned this pull request

Wildcard domain causing parsing issues #32

Closed

LukasGentele requested a review from FabianKramm

January 1, 2021 15:51

Member

FabianKramm commented Jan 4, 2021

@WilliamDASILVA thanks for opening this PR! Looks good to me!

FabianKramm merged commit 2802d72 into loft-sh:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment