-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(e2e): add provider test cases #11
Conversation
ENG-1107 DevPod E2E Tests
Create a couple of e2e tests that make sure DevPod works correctly with the Local Provider. We need:
Approach: ~4-6 hours
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kristoffn thanks for the PR! Please take a look at my comments
|
||
// Update provider 2 | ||
err = f.DevPodProviderUpdate([]string{"provider2", tempDir + "/provider2-update.yaml"}) | ||
framework.ExpectNoError(err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we ensure here that the provider was actually updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
framework.ExpectNoError(err) | ||
|
||
// Cleanup: delete provider 2 | ||
err = f.DevPodProviderDelete([]string{"provider2"}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we ensure here that the provider was actually deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds smoke test cases for the
devpod provider
subcommand