-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add e2e framework #6
Conversation
ENG-1107 DevPod E2E Tests
Create a couple of e2e tests that make sure DevPod works correctly with the Local Provider. We need:
|
e2e/tests/up/up.go
Outdated
} | ||
|
||
ginkgo.It("should start a new workspace with a local provider", func() { | ||
tempDir, err := framework.CopyToTempDir("tests/up/testdata/local-provider") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put an actual devcontainer.json into the testdata folder that is used
e2e/tests/up/up.go
Outdated
|
||
err = upCmd.RunE(nil, []string{tempDir}) | ||
framework.ExpectNoError(err) | ||
fmt.Println("got to the end") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check if the workspace is actually usable. To check if a workspace is usable, run:
ssh local-test.devpod -- echo FromContainter
and check if return is FromContainer
e2e/tests/up/up.go
Outdated
panic(err) | ||
} | ||
|
||
ginkgo.It("should start a new workspace with a local provider", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove debug fmt.Println's
e2e/README.md
Outdated
ginkgo e2e/... | ||
``` | ||
|
||
#### Run a specific e2e test suite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update here
pkg/workspace/provider.go
Outdated
@@ -83,6 +84,7 @@ func UpdateProvider(devPodConfig *config.Config, providerName, providerSourceRaw | |||
} | |||
|
|||
func resolveProvider(providerSource string, log log.Logger) ([]byte, *provider2.ProviderSource, error) { | |||
fmt.Println("provider source: ", providerSource) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this here
No description provided.